New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out anchors and metadata collections for UC assets #8435

Merged

mandy-chessell merged 2 commits into odpi:main from mandy-chessell:oak2024

Oct 8, 2024

Contributor

mandy-chessell commented Oct 8, 2024

Description

This PR corrects a recent regression in the unity catalog connector which resulted in the anchors and metadata collections for the resulting Unity Catalog assets to be confused. This was down to 2 mistakes:

the catalog target for all of these connectors is the server not the catalog - even for the inside catalog synchronizer. It was being treated as the catalog by the instide catalog synchronizer
the method that combined the configuration properties for the connector with the configuration properties for the catalog target was using the map of the connector. This meant properties from one catalog target was being seen by by another.

The last manual test I ran showed the server, catalog, schema, tables, functions and volumes were being catalogued correctly.


          Sort out anchors and metadata collections for UC assets

4aa680f

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>

mandy-chessell enabled auto-merge

October 8, 2024 18:18


          Merge branch 'main' into oak2024

20a6cdd

mandy-chessell merged commit b3a6287 into odpi:main

4 checks passed

github-advanced-security bot found potential problems

View reviewed changes

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to create this type of element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public String createMetadataElementInStore(String            metadataElementTypeName,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.createMetadataElementInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to create this type of element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public String getMetadataElementFromTemplate(String                         metadataElementTypeName,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.getMetadataElementFromTemplate

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to create this type of element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public String getMetadataElementFromTemplate(String                         externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.getMetadataElementFromTemplate

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to update this element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void updateMetadataElementInStore(String            externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.updateMetadataElementInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to update this element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void updateMetadataElementStatusInStore(String        externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.updateMetadataElementStatusInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to update this element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void updateClassificationEffectivityInStore(String  externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.updateClassificationEffectivityInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to create this type of relationship
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public String createRelatedElementsInStore(String            externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.createRelatedElementsInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to update this relationship
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void updateRelatedElementsInStore(String            externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.updateRelatedElementsInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to update this element
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void updateRelatedElementsEffectivityInStore(String  externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.updateRelatedElementsEffectivityInStore

; it is advisable to add an Override annotation.

...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java

+                   * @throws UserNotAuthorizedException the governance action service is not authorized to delete this relationship
+                   * @throws PropertyServerException there is a problem with the metadata store
+                   */
+                  public void deleteRelatedElementsInStore(String  externalSourceGUID,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataStore.deleteRelatedElementsInStore

; it is advisable to add an Override annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet