Additions to secrets connectors #8402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
| /** | ||
| * Request that the subclass refreshes its secrets. | ||
| */ | ||
| protected void refreshSecrets() |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @return how long the secrets can be cached - 0 means indefinitely | ||
| * @throws ConnectorCheckedException there is a problem with the connector | ||
| */ | ||
| public long getRefreshTimeInterval() throws ConnectorCheckedException |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
| * @param tokenAPI request specification | ||
| * @return new token or null | ||
| */ | ||
| private String getToken(TokenAPI tokenAPI) |
Check notice
Code scanning / CodeQL
Useless parameter Note
| /** | ||
| * Request that the subclass refreshes its secrets. | ||
| */ | ||
| protected void refreshSecrets() |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the audit log is pushed down to the Resource connectors and then on to the REST API Connectors and secrets connectors.
It also extends the secrets store token API to include contentType and requestType.
Related Issue(s)
None
Testing
Unit testing sending bearer token to Unity Catalog
Release Notes & Documentation
These are bug fixes
Additional notes
None