Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify engine host config #8015

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR simplifies the way that an engine host is configured. The names of the engines used to be dispersed among the appropriate engine services configuration. Each engine name had to be associated with the right engine service. Now the names of the engines are added on a separate list and the engine services only need to be configured if they are to use a different metadata server to the engine host servicer itself.

During server startup, the enghine host woorks out which engine serivce to associate the engine with.

The original way of configuring the engin host still works too.

Related Issue(s)

None

Testing

Running survey action services in an engine host configured both using the original configuration method and the new one.

Release Notes & Documentation

This needs to go in the release notes - and the admin guide needs updating - in progress.

Additional notes

None

Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
@mandy-chessell mandy-chessell merged commit 44797c8 into odpi:main Jan 26, 2024
this.nodes = nodes;
}

public List<Edge> getEdges() {
public List<Edge> getEdges()

Check notice

Code scanning / CodeQL

Exposing internal representation

getEdges exposes the internal representation stored in field edges. The value may be modified [after this call to getEdges](1). getEdges exposes the internal representation stored in field edges. The value may be modified [after this call to getEdges](2).
this.nodes = nodes;
this.edges = edge;
}

public List<RuleNode> getNodes() {
public List<RuleNode> getNodes()

Check notice

Code scanning / CodeQL

Exposing internal representation

getNodes exposes the internal representation stored in field nodes. The value may be modified [after this call to getNodes](1). getNodes exposes the internal representation stored in field nodes. The value may be modified [after this call to getNodes](2).
}


static class AnnotationSummary

Check notice

Code scanning / CodeQL

Unused classes and interfaces

Unused class: AnnotationSummary is not referenced within this codebase. If not used as an external API it should be removed.
GovernanceEngineConfigurationClient configurationClient,
GovernanceContextClient governanceActionClient,
EngineServiceConfig engineServiceConfig) throws OMAGConfigurationErrorException;
public abstract void initialize(String localServerId,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'localServerId' is never used.
String localServerName,
AuditLog auditLog,
String localServerUserId,
String localServerPassword,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'localServerPassword' is never used.
String localServerUserId,
String localServerPassword,
int maxPageSize,
GovernanceEngineConfigurationClient configurationClient,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'configurationClient' is never used.
String localServerPassword,
int maxPageSize,
GovernanceEngineConfigurationClient configurationClient,
GovernanceContextClient governanceActionClient,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'governanceActionClient' is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants