-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify engine host config #8015
Conversation
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
...n/java/org/odpi/openmetadata/accessservices/datamanager/properties/APIManagerProperties.java
Show resolved
Hide resolved
...a/org/odpi/openmetadata/adminservices/configuration/properties/EngineHostServicesConfig.java
Show resolved
Hide resolved
...a/org/odpi/openmetadata/adminservices/configuration/properties/EngineHostServicesConfig.java
Show resolved
Hide resolved
...org/odpi/openmetadata/adminservices/configuration/registration/EngineServiceDescription.java
Show resolved
Hide resolved
.../src/main/java/org/odpi/openmetadata/adminservices/client/ViewServerConfigurationClient.java
Show resolved
Hide resolved
this.nodes = nodes; | ||
} | ||
|
||
public List<Edge> getEdges() { | ||
public List<Edge> getEdges() |
Check notice
Code scanning / CodeQL
Exposing internal representation
this.nodes = nodes; | ||
this.edges = edge; | ||
} | ||
|
||
public List<RuleNode> getNodes() { | ||
public List<RuleNode> getNodes() |
Check notice
Code scanning / CodeQL
Exposing internal representation
} | ||
|
||
|
||
static class AnnotationSummary |
Check notice
Code scanning / CodeQL
Unused classes and interfaces
GovernanceEngineConfigurationClient configurationClient, | ||
GovernanceContextClient governanceActionClient, | ||
EngineServiceConfig engineServiceConfig) throws OMAGConfigurationErrorException; | ||
public abstract void initialize(String localServerId, |
Check notice
Code scanning / CodeQL
Useless parameter
String localServerName, | ||
AuditLog auditLog, | ||
String localServerUserId, | ||
String localServerPassword, |
Check notice
Code scanning / CodeQL
Useless parameter
String localServerUserId, | ||
String localServerPassword, | ||
int maxPageSize, | ||
GovernanceEngineConfigurationClient configurationClient, |
Check notice
Code scanning / CodeQL
Useless parameter
String localServerPassword, | ||
int maxPageSize, | ||
GovernanceEngineConfigurationClient configurationClient, | ||
GovernanceContextClient governanceActionClient, |
Check notice
Code scanning / CodeQL
Useless parameter
Description
This PR simplifies the way that an engine host is configured. The names of the engines used to be dispersed among the appropriate engine services configuration. Each engine name had to be associated with the right engine service. Now the names of the engines are added on a separate list and the engine services only need to be configured if they are to use a different metadata server to the engine host servicer itself.
During server startup, the enghine host woorks out which engine serivce to associate the engine with.
The original way of configuring the engin host still works too.
Related Issue(s)
None
Testing
Running survey action services in an engine host configured both using the original configuration method and the new one.
Release Notes & Documentation
This needs to go in the release notes - and the admin guide needs updating - in progress.
Additional notes
None