Enable framework serivces in Asset Manager OMAS #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
Signed-off-by: Mandy Chessell <mandy.e.chessell@gmail.com>
| Objects.equals(properties, that.properties) && | ||
| Objects.equals(templateGUID, that.templateGUID); | ||
| return Objects.equals(typeName, that.typeName) && initialStatus == that.initialStatus && | ||
| Objects.equals(effectiveFrom, that.effectiveFrom) && Objects.equals(effectiveTo, that.effectiveTo) && |
There was a problem hiding this comment.
💬 2 similar findings have been found in this PR
UndefinedEquals: Date does not have well-defined equals behavior.
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| open-metadata-implementation/framework-services/gaf-metadata-management/gaf-metadata-api/src/main/java/org/odpi/openmetadata/commonservices/gaf/rest/NewMetadataElementRequestBody.java | 268 |
| open-metadata-implementation/framework-services/gaf-metadata-management/gaf-metadata-api/src/main/java/org/odpi/openmetadata/commonservices/gaf/rest/NewMetadataElementRequestBody.java | 266 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mandy Chessell mandy.e.chessell@gmail.com
Description
This PR:
* Support for creating connectors
* Support for the open metadata store
* Support for the open metadata governance function such as managing metadata valid values, translations and creating incident reports.
This fix is the first time that the open metadata store has been used in an OMIS. It needed to be extended to allow the maintenance of metadata from external metadata collections.
Related Issue(s)
None
Testing
Build, UT, FVT
Release Notes & Documentation
Asset Manager OMAS and Catalog Integrator OMIS documentation needs extending to acknowledge this extra support.