(Release 3.14) Fix CTS (revert header change) #7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f46032. Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
|
Do not merge yet until retested |
...ices/connectors/stores/metadatacollectionstore/properties/instances/InstanceAuditHeader.java
Show resolved
Hide resolved
...ices/connectors/stores/metadatacollectionstore/properties/instances/InstanceAuditHeader.java
Show resolved
Hide resolved
lpalashevski
approved these changes
Dec 20, 2022
|
A fix omitting the header change, passes CTS. @lpalashevski suggest we merge this now & retest after merge+release pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f46032.
Signed-off-by: Nigel Jones nigel.l.jones+git@gmail.com
Description
This reverts the final commit in 7f46032 which was an optional cherry pick to fix
a missing header version.
With this final fix CTS fails, however two remaining commits do fix CTS, and are needed for 3.14
I suggest persuing the header fix in 3.15/main only. The cts failures in the graph repo may be due to conflict resolution or the actual fix, but are not essential for 3.14
Related Issue(s)
Testing
Built a docker image without the final fix for header version (I reapplied rather than reverted, but end result should be same)
Ran graph CTS which passed with 0 errors
Release Notes & Documentation
Additional notes