-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DE Proxy - use ProcessingState classification for saving sync time in DS connector #7009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DS connector Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
…ing state classification Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
...rg/odpi/openmetadata/governanceservers/dataengineproxy/processor/DataEngineProxyService.java
Show resolved
Hide resolved
...rg/odpi/openmetadata/governanceservers/dataengineproxy/processor/DataEngineProxyService.java
Show resolved
Hide resolved
...rc/main/java/org/odpi/openmetadata/accessservices/dataengine/event/ProcessingStateEvent.java
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/accessservices/dataengine/client/DataEngineRESTClient.java
Show resolved
Hide resolved
|
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
...c/main/java/org/odpi/openmetadata/accessservices/dataengine/client/DataEngineRESTClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
…nector v1 (no reports) Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
...rg/odpi/openmetadata/governanceservers/dataengineproxy/processor/DataEngineProxyService.java
Show resolved
Hide resolved
popa-raluca
approved these changes
Nov 7, 2022
lpalashevski
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with 2 minor comments coming from sonatype lift scan.
...rc/main/java/org/odpi/openmetadata/accessservices/dataengine/event/ProcessingStateEvent.java
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/accessservices/dataengine/client/DataEngineRESTClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/accessservices/dataengine/client/DataEngineRESTClient.java
Show resolved
Hide resolved
open-metadata-implementation/access-services/data-engine/data-engine-client/build.gradle
Outdated
Show resolved
Hide resolved
...rg/odpi/openmetadata/governanceservers/dataengineproxy/processor/DataEngineProxyService.java
Show resolved
Hide resolved
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
...rc/main/java/org/odpi/openmetadata/accessservices/dataengine/event/ProcessingStateEvent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandra Bucur <alexandra-nona.bucur@ing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now the sync state of the Data Stage Proxy was saved in the IGC rules. These changes move the sync state into the ProcessingState classification that is related to an Engine entity.
Also, this PR includes the remaining pieces for the refactoring from SoftwareServerCapability to Engine.
Testing
Manually with IGC, Data Stage Proxy, IBM Proxy, Data Engine, UI + JUnits + FVTs