-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTS failing (graph, xtdb) for last 2 days — since dependabot updates #7618
Comments
Reviewing the included commits, none immediately stand-out as the cause of the regression. However we have now had multiple days of failure. I therefore plan to retest starting with HEAD at the commit immediately prior to the dependabot changes. |
@lpalashevski @alexandra-bucur elasticsearch was updated 8.6.2 -> 8.7.0 in bf6276b This also pulls in some lucene update I'll start a CTS run reverting this commit |
@planetf1 I tried to use the graph with the older version and does not seem to work. Do you think it's related?
|
@alexandra-bucur I only looked briefly, but it's in graph indexes, so lucene related, and the elastic search update did pull something in. Also XTDB is affected, which is also using lucene. I've built a fix and just about to kick off CTS (but it takes 3-4 hours to run) |
Draft PR: #7622 - has links to test run & image. Will revisit later/tomorrow. Speculative for now... |
the particular error was not finding I will let the CTS run. The issue there may be different (I didn't see this error, but the cts run didn't capture all the log). |
See also #7624 -- conclusion is that FVT tests on graph haven't worked in a long time. Will put addressing that to one side & return to the current regression which has happened recently. |
CTS test run (graph) on k8s (latest code in main) -
|
Step 10 of building a data catalog notebook fails to find assets using graph when using a search string of ```
|
The exception trace is the same as yours @alexandra-bucur This occurs both at HEAD AND prior to the dependabot changes This suggests the change may in fact have been due to an external source -- perhaps a change in published lucene packages My initial error (running locally) was due to having some old connectors in my classpath ie
Cleaning and retrying ... Get exception picking up class from egeria
This seems relevant
This implies we need a Lucene 8 implementation We have lucene constrained to 8.11.1 - Janusgraph prereqs Lucene latest version is 9.5 - 8.11.2 is the latest 8.x Related, elasticsearch is 8.7.0 (lucene 9.5.0)- which is the latest. this was 8.6.2 previously (lucene 9.4.2) Latest Janusgraph is 0.6.2 (we are using 0.6.1) which prereqs lucene 8.9 Given that reverting dependencies doesn't seem to work (unsure why), other options include
Try 2
|
The two minor updates appear to address the issue. |
…issue Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
regression re-testing on our end in progress |
|
Cts has failed for graph with the same error as before. I therefore think the fix is not sufficient. Unsure why it seemed to fix the issue locally |
Tested locally
Tested in k8s
@lpalashevski @alexandra-bucur how is your testing going? |
CTS succeeded last night, having failed in the days previously even after caches were deleted 3 days prior Some changes were included from @mandy-chessell though I have no explanation for why this is now working |
closing as fixed |
For the last two dats CTS is failing.
See https://github.com/odpi/egeria-test-cts/actions
Whilst these may be transient, two PRs were merged on Friday which could have impacted CTS: (prior to Friday the tests were clean)
The text was updated successfully, but these errors were encountered: