Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

Re-organize to reflect JuMP requirements #100

Merged
merged 8 commits into from
Dec 6, 2019
Merged

Re-organize to reflect JuMP requirements #100

merged 8 commits into from
Dec 6, 2019

Conversation

odow
Copy link
Owner

@odow odow commented Dec 6, 2019

This PR makes a number of changes to reflect functionality required by jump-dev/JuMP.jl#2114.

In particular, models now implement read! and write on io streams, and we provide a new_model function which takes a FileFormat enum and an (optional) filename string, and returns a new model object.

I've also removed the ability to specify a compression scheme when reading and writing to file in favor of AutomaticCompression. The reason being that users with different schemes should just use read!/write on the compressed io stream.

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #100 into master will increase coverage by 0.01%.
The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   96.17%   96.19%   +0.01%     
==========================================
  Files           9        9              
  Lines        1256     1261       +5     
==========================================
+ Hits         1208     1213       +5     
  Misses         48       48
Impacted Files Coverage Δ
src/MPS/MPS.jl 99.23% <ø> (ø) ⬆️
src/MOF/read.jl 92.98% <ø> (ø) ⬆️
src/CBF/CBF.jl 99.23% <ø> (ø) ⬆️
src/MOF/write.jl 67.77% <ø> (ø) ⬆️
src/LP/LP.jl 97.64% <100%> (ø) ⬆️
src/MOF/MOF.jl 100% <100%> (ø) ⬆️
src/MathOptFormat.jl 100% <100%> (+5.08%) ⬆️
src/utils.jl 95.45% <95.45%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1032f7...520deba. Read the comment docs.

@odow odow merged commit b135209 into master Dec 6, 2019
@odow odow deleted the od/jump branch December 6, 2019 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants