Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FBAdSettings.setAdvertiserTrackingEnabled #273

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

ernest0vm
Copy link
Contributor

@ernest0vm ernest0vm commented Nov 25, 2022

  • upgrade FBSDKCoreKit to v15.1
  • upgrade FBAudienceNetwork to v6.12
  • add FBAdSettings.setAdvertiserTrackingEnabled within handleSetAdvertiserTracking method for iOS platform.

image

https://developers.facebook.com/docs/app-events/guides/advertising-tracking-enabled/

…etAdvertiserTracking` method for iOS platform
Copy link
Contributor

@ferysyukur ferysyukur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityawibisana
Copy link
Contributor

@ferysyukur :
Is
FBAdSettings.setAdvertiserTrackingEnabled(enabled)

Equals to:
Settings.shared.isAdvertiserTrackingEnabled = enabled ?

Legacy code should be more correct to me, only set it when we allow it.

@DennisAlund DennisAlund merged commit ccf5c85 into oddbit:develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update Facebook SDK [Bug]: Symbol not found: _FBLinkable_NSBundle_InfoDictionaryProviding
4 participants