Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added connection of AppDelegate & sdk #236

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Techblogogy
Copy link
Contributor

This might be a "controversial change", but I've encountered an issue on my end, maybe someone else encountered something similar.

In "Facebook Events Manager" for my project, I needed to "configure app Events for SKAdNetwork" on iOS side of things.

image

Before you can do it, you have to go through verification procedure, where they send you a notification to a facebook app on your phone, which then opens up you app.

When running this verification, it kept failing, right until a moment I've introduced changes suggested in this PR.

Maybe my solution was just a fluke, but it helped me, so I've decided to submit it for review, just in case somebody else encounters something similar.

@ibrahimdevs ibrahimdevs mentioned this pull request Jul 26, 2022
1 task
@ibrahimdevs
Copy link

@DennisAlund thanks for great work. Could you check this pull request?
Facebook force this update to track app events without Add Tracking Permission.

@ndahlquist
Copy link

Confirmed that this fix worked for us too.

Before this patch:

  • The "Verify your app's deep link" flow in Facebook Events Manager successfully opened the app, but did not complete the verification.

After this patch:

  • We were able to complete the deep link verification flow successfully.

Thank you @Techblogogy!

@bhavik-multipl
Copy link

Will it take time to merge this PR?

@DennisAlund DennisAlund linked an issue Sep 21, 2022 that may be closed by this pull request
1 task
Copy link
Member

@DennisAlund DennisAlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good. I am making a note for the future whether it will be necessary to also implement the SceneDelegate as mentioned needed for iOS13

@DennisAlund DennisAlund merged commit 8bca71d into oddbit:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregated Event Measurement
5 participants