Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch update permissions errors #79

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Fix branch update permissions errors #79

merged 8 commits into from
Jul 26, 2024

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Jul 25, 2024

We've been seeing EPERM errors on branch updates for dotnet-sdk-enterprise-server. This was due to a mistake in the way the branch was being created locally: since the check was only seeing the branch not existing locally, not on the remote, a new branch was always being created from the main branch. When fetching that branch from the remote and trying to replay those changes on top of the locally created branch, conflicts arose.

This PR should fix those changes, as demonstrated by a failing build in .NET here followed by a successful .NET build here and a successful Go build here.

@kfcampbell kfcampbell closed this Jul 25, 2024
@kfcampbell kfcampbell deleted the try-old-pat branch July 25, 2024 18:11
@kfcampbell kfcampbell restored the try-old-pat branch July 25, 2024 18:15
@kfcampbell kfcampbell reopened this Jul 25, 2024
@kfcampbell kfcampbell changed the title Testing for permissions errors Fix branch update permissions errors Jul 25, 2024
@kfcampbell kfcampbell marked this pull request as ready for review July 25, 2024 21:56
@kfcampbell kfcampbell requested a review from nickfloyd July 25, 2024 21:56
@nickfloyd nickfloyd merged commit 73e17cf into main Jul 26, 2024
28 checks passed
@nickfloyd nickfloyd deleted the try-old-pat branch July 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants