Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command example fix in documentation. #989

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Conversation

europ
Copy link
Contributor

@europ europ commented Mar 5, 2018

Fix of wrong example with 3 arguments while 4 arguments are required in documentation. Example is connected to the function 'dismiss_pull_request_review'.

Closes #988

\cc @tarebyte

Fix of wrong example with 3 arguments while 4 arguments are required in documentation. Example is connected to the function 'dismiss_pull_request_review'.

Related issue: octokit#988
Copy link
Contributor

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @europ ⚡️

@kytrinyx kytrinyx merged commit a06d163 into octokit:master Mar 9, 2018
@europ europ deleted the doc_fix branch March 9, 2018 15:27
@tarebyte
Copy link
Member

tarebyte commented May 8, 2018

This has been released as part of https://github.com/octokit/octokit.rb/releases/tag/v4.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants