Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to vitest #648

Merged
merged 7 commits into from
Oct 3, 2024
Merged

build: switch to vitest #648

merged 7 commits into from
Oct 3, 2024

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Oct 3, 2024

  • build: switch to vitest
  • build: remove jest configuration

Before the change?

  • Use Jest for tests

After the change?

  • Use vitest for tests

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link

github-actions bot commented Oct 3, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Oct 3, 2024
@oscard0m oscard0m requested a review from wolfy1339 October 3, 2024 22:09
package.json Outdated Show resolved Hide resolved
@wolfy1339
Copy link
Member

There are comments inside index.ts that ignore certain functions from coverage, they should be converted to use v8 instead of istanbul.

package.json Outdated Show resolved Hide resolved
@oscard0m oscard0m requested a review from wolfy1339 October 3, 2024 22:49
@wolfy1339 wolfy1339 merged commit d0f3ad0 into main Oct 3, 2024
6 checks passed
@wolfy1339 wolfy1339 deleted the switch-to-vitest branch October 3, 2024 22:50
@oscard0m oscard0m changed the title switch to vitest build: switch to vitest Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants