Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovenian language added #4796

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Slovenian language added #4796

merged 7 commits into from
Dec 10, 2019

Conversation

BlazOrazem
Copy link
Contributor

I created new language files for Slovenian language, in which I translated english phrases. Afterwards I tested the CMS through and through with the Slovenian language, made some corrections and now everything looks great. I also translated Froala language file and system assets JS language file. Besides that I added Slovenian language to all other system language files and added a Slovenian language selection with an appropriate flag to the Preference model.

@LukeTowers
Copy link
Contributor

Thanks for your contributions @BlazOrazem! As this is a large PR with a lot to review we'll hold off merging it until after we've finished Build 460.

@bennothommo
Copy link
Contributor

@BlazOrazem With the language changes made for Froala, would you mind submitting a PR to their repo to have the Slovenian language file added: https://github.com/froala/wysiwyg-editor. If we decide to update Froala, we will more than likely use their language files.

@BlazOrazem
Copy link
Contributor Author

@BlazOrazem With the language changes made for Froala, would you mind submitting a PR to their repo to have the Slovenian language file added: https://github.com/froala/wysiwyg-editor. If we decide to update Froala, we will more than likely use their language files.

Good idea @bennothommo , I created a PR to their repo: froala/wysiwyg-editor#3752

@bennothommo
Copy link
Contributor

@BlazOrazem awesome!

@daftspunk daftspunk merged commit 8abed17 into octobercms:develop Dec 10, 2019
@daftspunk
Copy link
Member

Thanks @BlazOrazem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants