Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show table scrolling a bit clearer - ux fix #4629

Merged
merged 3 commits into from Sep 21, 2019
Merged

Show table scrolling a bit clearer - ux fix #4629

merged 3 commits into from Sep 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2019

This relates to this comment: #4618 (comment)

Large screens (non-scrolling mode)

image

Smaller screens (scrolling mode)

image

p.s. I can't take screenshots of the mouse cursor so I added them in - that's why they look a big strange. But you get the basic idea.

@ghost
Copy link
Author

ghost commented Sep 19, 2019

@LukeTowers @bennothommo Something seems wrong with Travis, please can you look into it. The last three PR's all failed. This is the error msg:

There was 1 error:

1) UpdaterTest::testClassNameGetsParsedCorrectly

ReflectionException: Class October\Rain\Tests\fixtures\Database\SampleClass does not exist

/home/travis/build/octobercms/october/vendor/october/rain/tests/Database/UpdaterTest.php:15

@bennothommo
Copy link
Contributor

@ayumihamasaki2019 Travis CI should be fixed now, on your next commit. :)

@LukeTowers LukeTowers added this to the v1.0.460 milestone Sep 20, 2019
@ghost
Copy link
Author

ghost commented Sep 20, 2019

@bennothommo Perfect, thank you!

@LukeTowers All done, pls re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants