Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$filePath -> &$filePath in media.file.upload event #4612

Merged
merged 2 commits into from
Sep 10, 2019
Merged

$filePath -> &$filePath in media.file.upload event #4612

merged 2 commits into from
Sep 10, 2019

Conversation

pavelmgn
Copy link
Contributor

Passing by reference a variable in an event 'media.file.upload' in the media library

@pavelmgn pavelmgn changed the title Pavel Sidorov $filePath -> &$filePath in media.file.upload event Sep 10, 2019
@LukeTowers
Copy link
Contributor

@pavelmgn can you update the two examples in the docblock for this event to have the & too?

@pavelmgn
Copy link
Contributor Author

@LukeTowers seems to have done

@LukeTowers LukeTowers merged commit 868c7ec into octobercms:master Sep 10, 2019
LukeTowers added a commit that referenced this pull request Sep 10, 2019
LukeTowers added a commit that referenced this pull request Sep 10, 2019
@LukeTowers
Copy link
Contributor

@pavelmgn please resubmit to the develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants