Replace use of parseJSON with JSON.parse

[danharrin]

This replaces the use of jQuery's parseJSON with its Vanilla alternative, JSON.parse.

[w20k]

Why exactly @danharrin? Micro optimization? :)

Minor note: PRs without description will be closed in future.

[danharrin]

Yup @w20k, I should be doing a few of these PRs. There is really no reason to be relying on jQuery in these situations when there are well-browser-supported Vanilla alternatives. As well as very minor optimisation improvements, these changes allow for better developer understanding of October's codebase, without prior knowledge of jQuery.

I've just added another fix for isArray to this PR.

[w20k]

@danharrin add all the fixes or what you did in the description ;) Thanks!

[danharrin]

@w20k all done :)

[danharrin]

That fix is done, anything else @w20k?

[w20k]

@danharrin should be all ;) Will quickly test, after you're done, and ready for the next release 458.

[danharrin]

All done @w20k :) also just added some very simple parseJSON to JSON.parse replacements.

[danharrin]

Hey @w20k, any reason in particular why this was blocked?

[w20k]

@danharrin it's labeled blocked just to ensure it won't be merged or processed before the next build. Those are waiting for their turn :)

[LukeTowers]

@danharrin what's the browser support for these changes? Specifically IE.

[danharrin]

@LukeTowers
indexOf() and isArray() are both IE9+.
JSON.parse() is IE8+.

[LukeTowers]

As well as very minor optimisation improvements, these changes allow for better developer understanding of October's codebase, without prior knowledge of jQuery.

I feel like these methods are more clear (except perhaps in the case of the JSON) as their jQuery counterparts instead.

[w20k]

Jquery under the hood is using those as well :) Pretty much, only null && undefined check is added.

[LukeTowers]

@danharrin alright, can you change this to only be the parseJSON replacement?

[danharrin]

Will sort out now @LukeTowers 👍

[danharrin]

@LukeTowers done it sorry, got sidetracked 😆

[LukeTowers]

@danharrin can you merge develop into your branch and run the compile again?

[danharrin]

Sorted @LukeTowers 👍

[w20k]

@LukeTowers I guess it could be merged.

From jQuery Dev build 😄: jQuery.parseJSON = JSON.parse;
https://code.jquery.com/jquery-3.4.1.js