-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bangla Translation & New Arabic Translation Update #16
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions #13 succeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#16 (review) github-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Bangla Translations & Arabic *NEW
#16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gh pr checkout 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gh pr checkout 16
Thank you very much for the contribution! Sorry for the delay in reviewing it! I wanted to spend extra time testing the Arabic layout since it is the first bidirectional script being translated for Octave Online Server. I pushed a commit 71ebde0 to fix a JSON parse error. You had The text comes out correctly in most cases, but there are some odd artifacts. For example, in the "Sign in with Email" screen, the bi-di for the message at the bottom about HTTP/HTTPS seems messed up: This is the ordered concatenation of these three sentences into a paragraph:
As plain text:
As HTML:
The bi-di works correctly when it is plain text but not HTML. Could you help debug? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
htrafsan:main
-> Arabic Translation Update *New
-> Edited some words in Bangla Translation
HASAN TAHSIN RAFSAN
@rafsanofficial on twitter