Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bangla Translation & New Arabic Translation Update #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

htrafsan
Copy link

-> Arabic Translation Update *New
-> Edited some words in Bangla Translation


HASAN TAHSIN RAFSAN
@rafsanofficial on twitter

Copy link
Contributor

@rafsanofficial rafsanofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-actions #13 succeed

Copy link
Contributor

@rafsanofficial rafsanofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16 (review) github-actions

Copy link
Author

@htrafsan htrafsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Bangla Translations & Arabic *NEW
#16

Copy link
Contributor

@rafsanofficial rafsanofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16

Copy link
Contributor

@rafsanofficial rafsanofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16

@rafsanofficial
Copy link
Contributor

gh pr checkout 16

Copy link
Contributor

@rafsanofficial rafsanofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh pr checkout 16

@sffc
Copy link
Contributor

sffc commented Apr 21, 2022

Thank you very much for the contribution! Sorry for the delay in reviewing it!

I wanted to spend extra time testing the Arabic layout since it is the first bidirectional script being translated for Octave Online Server.

I pushed a commit 71ebde0 to fix a JSON parse error. You had \ characters which I replaced with \". I tried to push it to your branch but I don't have permission.

The text comes out correctly in most cases, but there are some odd artifacts. For example, in the "Sign in with Email" screen, the bi-di for the message at the bottom about HTTP/HTTPS seems messed up:

Screen Shot 2022-04-21 at 12 24 58 AM

This is the ordered concatenation of these three sentences into a paragraph:

  1. common.caution#label
  2. common.https#p
  3. common.https#btn

As plain text:

الحذر: أنت تستخدم اتصالاً غير آمن (http). قد يتمكن الأشخاص من رؤية ما ترسله. التبديل إلى اتصال آمن (https)

As HTML:

<p><strong>الحذر:</strong> أنت تستخدم اتصالاً غير آمن (http). قد يتمكن الأشخاص من رؤية ما ترسله. <a href="https://127.0.0.1:8080/?lng=ar">التبديل إلى اتصال آمن (https)</a></p>

The bi-di works correctly when it is plain text but not HTML. Could you help debug?

officialrafsan
officialrafsan approved these changes May 22, 2022
Copy link
Author

@htrafsan htrafsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

htrafsan:main

@htrafsan htrafsan closed this Jun 15, 2022
@htrafsan htrafsan reopened this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants