Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated robotjs to compile with nan-2.0.9 #87

Merged
merged 3 commits into from
Sep 29, 2015
Merged

updated robotjs to compile with nan-2.0.9 #87

merged 3 commits into from
Sep 29, 2015

Conversation

abhishekgarg120
Copy link
Contributor

No description provided.

@octalmage
Copy link
Owner

Thanks for this! I have a few comments, I'll comment on the relevant lines.


MMPoint point;
point = MMPointMake(x, y);
moveMouse(point);
microsleep(mouseDelay);

NanReturnValue(NanNew("1"));
// info.GetReturnValue().Set(Nan::New(1));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented out for a reason? This is what caused the tests to fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is commented out by mistake. Let me fix this

@abhishekgarg120
Copy link
Contributor Author

This now works with the latest Nodejs v4.0.0

@octalmage
Copy link
Owner

Thanks! The io.js v3 test is still failing, but I think that's a separate issue (travis config). I'll look into it later today.

@octalmage
Copy link
Owner

Hey @abhishekgarg120!

Could you change your .travis.yml to this and commit it to this PR?

sudo: false
language: node_js
env:
  - CXX=g++-4.8
node_js:
  - 0.10
  - 0.12
  - 4.0.0
  - iojs-v2
  - iojs-v3

matrix:
  allow_failures:
    - node_js: iojs-v3
    - node_js: 4.0.0

addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - libx11-dev
      - zlib1g-dev
      - libpng12-dev
      - libxtst-dev
      - g++-4.8

before_script:
  - export DISPLAY=:99.0
  - sh -e /etc/init.d/xvfb start

Or if you're busy, can you add me as a collaborator to your fork?

Thanks!

@abhishekgarg120
Copy link
Contributor Author

Done, updated the travis config file

@octalmage octalmage mentioned this pull request Sep 20, 2015
@ChALkeR
Copy link

ChALkeR commented Sep 20, 2015

Adding to the list: nodejs/node#2798.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants