-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated robotjs to compile with nan-2.0.9 #87
Conversation
Thanks for this! I have a few comments, I'll comment on the relevant lines. |
|
||
MMPoint point; | ||
point = MMPointMake(x, y); | ||
moveMouse(point); | ||
microsleep(mouseDelay); | ||
|
||
NanReturnValue(NanNew("1")); | ||
// info.GetReturnValue().Set(Nan::New(1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this commented out for a reason? This is what caused the tests to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commented out by mistake. Let me fix this
This now works with the latest Nodejs v4.0.0 |
Thanks! The io.js v3 test is still failing, but I think that's a separate issue (travis config). I'll look into it later today. |
Hey @abhishekgarg120! Could you change your .travis.yml to this and commit it to this PR?
Or if you're busy, can you add me as a collaborator to your fork? Thanks! |
Done, updated the travis config file |
Adding to the list: nodejs/node#2798. |
No description provided.