Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph to handle direct and indirect recursion #93

Merged
merged 1 commit into from
May 25, 2024

Conversation

rmouritzen-splunk
Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk commented May 25, 2024

  • Re-enable graph feature with fixes to handle indirectly recursive definitions, eliminating infinite loops.
  • Remove try/rescue usage in page_controller as it returns internal implementation details, which is a security risk. Instead letting the Phoenix framework (appropriately) return a generic Internal Server Error.
  • Remove /guidelines route and handling as the related guidelines.html doesn't exist.
  • Change prod log level to warning. Improve log format.

…initions, eliminating infinite loops. Remove try/rescue usage in page_controller as it returns internal implementation details, which is a security risk. Instead letting the Phoenix framework (appropriately) return a generic Internal Server Error. Remove /guidelines route and handling as the related guidelines.html doesn't exist.
@rmouritzen-splunk rmouritzen-splunk merged commit c64fa6b into ocsf:main May 25, 2024
1 check passed
@rmouritzen-splunk rmouritzen-splunk deleted the fix-graph branch May 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant