Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Disabling rmc in KVM script #60

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Disabling rmc in KVM script #60

merged 1 commit into from
Nov 3, 2020

Conversation

satwinder0867
Copy link
Contributor

@satwinder0867
Copy link
Contributor Author

These changes are made as the RMC container is not reqd for the Libvert cluster as per discussion b/w Archana and Manju.
^ ^@mkumatag

mkumatag
mkumatag suggested changes Oct 27, 2020
View reviewed changes
modules/5_install/templates/install_vars.yaml Outdated
@@ -18,3 +18,4 @@ chronyconfig:
options: ${lookup(item, "options", "iburst")}
%{ endfor ~}
%{ endif ~}
powervm_rmc: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just add a new line at the end

@mkumatag
Copy link
Member

Let's get the review comments from @yussufsh and @Prajyot-Parab as well.

@satwinder0867 satwinder0867 force-pushed the rmc-disabling branch 2 times, most recently from 1115e61 to 60aacf7 Compare October 30, 2020 07:11
@satwinder0867
Copy link
Contributor Author

@yussufsh @Prajyot-Parab
Extra line is added at the end, plz merge it

@mkumatag
Copy link
Member

@satwinder0867 fix the commit author, it says root at the moment,

how to fix - https://stackoverflow.com/questions/25339671/git-uses-root-instead-of-my-username-while-commit-linux

@satwinder0867 satwinder0867 force-pushed the rmc-disabling branch 2 times, most recently from 4fcb35a to fdebb65 Compare October 30, 2020 08:32
@mkumatag
Copy link
Member

If you look at the commit is still says - root authored and satwinder0867 committed 2 hours ago seems like still stuck with co-authored,

@satwinder0867
Copy link
Contributor Author

@mkumatag @yussufsh
i made changes again, hope this time its good to merge
let me know if any more changes are reqd.

@Prajyot-Parab
Copy link
Collaborator

@satwinder0867 Please refer to the below format, try to sign off your commit properly before pushing git commit -m <message> -s

<Commit Message>
Signed-off-by: <GH username> <Mail>

@satwinder0867 satwinder0867 force-pushed the rmc-disabling branch 5 times, most recently from 184a722 to bd601d1 Compare November 3, 2020 09:01
@satwinder0867
Disable RMC on kvm
bf812b0 
Signed-off-by: Satwinder <sati11114@gmail.com>
Prajyot-Parab
Prajyot-Parab approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

mkumatag
mkumatag approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yussufsh
yussufsh approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh yussufsh merged commit 9707bb4 into ocp-power-automation:master Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@yussufsh yussufsh yussufsh approved these changes

@mkumatag mkumatag mkumatag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satwinder0867 @mkumatag @Prajyot-Parab @yussufsh