Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] - Make dataType optional when providing retriever configurations #31

Closed
3 tasks done
pranav-kural opened this issue Jul 13, 2024 · 0 comments · Fixed by #32
Closed
3 tasks done

[Feature Request] - Make dataType optional when providing retriever configurations #31

pranav-kural opened this issue Jul 13, 2024 · 0 comments · Fixed by #32
Assignees
@pranav-kural
Labels
enhancement New feature or request

Comments

@pranav-kural
Copy link
Collaborator

Checklist

  • I have searched the existing issues and this feature has not been requested before.
  • I have checked the QvikChat Feature Release project and this feature is not listed there.
  • [] Optional: I have read the QvikChat documentation and there is no alternative to this feature.
  • [] Optional: I am willing to implement this feature and submit a pull request.

Description

Make dataType optional when providing retriever configurations. This can be inferred from the file extension using the provided filePath.

Proposal

Update getDataRetriever. Add utility method to infer file extension from given file path. Confirm if the extension belongs to one of the supported data files.

Select Components this Feature will Impact

Select component(s) this feature will impact

  • [] API Key Authentication
  • [] Chat Agents
  • [] Chat Endpoints
  • [] Chat History
  • [] Embedding Models
  • [] Endpoint Deployment
  • [] LLM Models
  • RAG
  • [] Response Caching
  • [] Vector Stores
  • [] Other
@pranav-kural pranav-kural added the enhancement New feature or request label Jul 13, 2024
@pranav-kural pranav-kural self-assigned this Jul 13, 2024
pranav-kural added a commit that referenced this issue Jul 14, 2024
@pranav-kural
added methods to infer data type from file extension #31
ddc1c96
pranav-kural added a commit that referenced this issue Jul 14, 2024
@pranav-kural
made dataType property optional in retriever config #31
8e855ec
@pranav-kural pranav-kural mentioned this issue Jul 14, 2024
Merged
@pranav-kural pranav-kural linked a pull request Jul 14, 2024 that will close this issue
Changes to make dataType optional + fix for peer dependencies #32
Merged
@pranav-kural pranav-kural moved this to In progress in QvikChat Project Jul 14, 2024
pranav-kural added a commit that referenced this issue Jul 14, 2024
@pranav-kural
Changes to make dataType optional + fix for peer dependencies (#32)
9a58767 
* added methods to infer data type from file extension #31

* made `dataType` property optional in retriever config #31

* Tested RAG endpoint without specifying `dataType`

* bumped package version + rolled back version of eslint and d3-dsv to fix dependency issues
@github-project-automation github-project-automation bot moved this from In progress to Done in QvikChat Project Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranav-kural pranav-kural

Labels
enhancement New feature or request
Projects
QvikChat Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes to make dataType optional + fix for peer dependencies oconva/qvikchat
1 participant
@pranav-kural