Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use require.cache to resolve root #543

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: use require.cache to resolve root #543

merged 2 commits into from
May 2, 2024
+8 −6

Conversation

mdonnalley
Copy link
Contributor

  • Use require.cache to find the importing file before attempting to traverse up the file system to find the root
  • Allow users to set OCLIF_TEST_ROOT env var to an absolute path to their CLI root

Fixes #542
@W-15643461@

mdonnalley and others added 2 commits April 30, 2024 14:24
@mdonnalley
fix: use require.cache to resolve root

Verified

This commit was signed with the committer’s verified signature.
mdonnalley Mike Donnalley
GPG key ID: F9EF3E11450D6976
Verified
Learn about vigilant mode
Loading
Loading status checks…
40387ad
@svc-cli-bot
chore(release): 3.2.12-dev.0 [skip ci]
Loading
Loading status checks…
7eb1051
@mdonnalley mdonnalley mentioned this pull request Apr 30, 2024
Closed
@mdonnalley mdonnalley merged commit ad0ef17 into main May 2, 2024
7 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/workspace-root branch May 2, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All tests using .command() fail with command X not found errors
2 participants
@mdonnalley @svc-cli-bot