This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
refactor: optimize filters for oras.ExtendedCopy
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
b88a48f to
c14a471
Compare
oras.ExtendedCopy
m5i-work
reviewed
Sep 23, 2022
shizhMSFT
suggested changes
Sep 23, 2022
extendedcopy.go
Outdated
| fp := opts.FindPredecessors | ||
| opts.FindPredecessors = func(ctx context.Context, src content.ReadOnlyGraphStorage, desc ocispec.Descriptor) ([]ocispec.Descriptor, error) { | ||
| var predecessors []ocispec.Descriptor | ||
| var err error | ||
| if fp == nil { | ||
| if rf, ok := src.(registry.ReferrerFinder); ok { |
There was a problem hiding this comment.
Just a note and not related to this PR: With OCI Artifact support, a registry.Repository should always be a registry.ReferrerFinder. We will have registry.Referrers(ctx context.Context, repo Repository) ([]string, error later.
wangxiaoxuan273
approved these changes
Sep 25, 2022
In the current implementation, the annotations and the artifact type can be indexed only if they are populated in the descriptor on pushing. |
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
rosanch
approved these changes
Sep 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Open Container Initiative Distribution Specification, the
ReferrersAPI must include theartifactTypeandannotationsof the referrers in the returned descriptor list. (Predecessorsalso supports this)Related to oras-project#310
Signed-off-by: Lixia (Sylvia) Lei lixlei@microsoft.com