Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.50] Lag on heroes screen when many coins have been selected. #208

Closed
carlosjeurissen opened this issue Jan 13, 2025 · 5 comments
Closed

Comments

@carlosjeurissen
Copy link
Contributor

As mentioned by @boingbloing in #206 (comment), if many coins have been collected, the heroes screen lags even on high-end devices.

A potential solution could be to above 10-20 coins simply display the coin icon with a number next to it instead of drawing all the collected coins.

@klaviartur
Copy link

+1
Preferrably in hex 😉

© × x3F

Indeed, I think it would be only logical to use hex all over the place, e.g. level numbers, chip upgrade level and so on.

@ochadenas
Copy link
Owner

Good idea. Numbers above 16 will be displayed as text only.

In decimal, however. At least for the moment. I'm not sure if everyone will like hex numbers. Perhaps introduce a global option for this.

ochadenas added a commit that referenced this issue Jan 18, 2025
@carlosjeurissen
Copy link
Contributor Author

@ochadenas Wonderful!

@ochadenas
Copy link
Owner

@klaviartur Following your idea, the level numbers can be displayed in hex now. But this must be activated in the settings.

It don't want to change everything in this game into hex, because I think that many players would be annoyed by this.

Image
Image

@klaviartur
Copy link

Nice 🤩

I understand, that this is not for everyone, but:
Since this is togglable, I'd like to plead once more for the "nerd mode", where this toggle toggles hex globally.
A toggle just for the level numbers feels like quite a waste 😉
I'd really like to upgrade from SHR x9 to SHR xA 🥹
And have Coins available: x1C.

In my imagination, as soon as the game introduces hex opponents it could ask you to decide between "make it all hex" and "only hex opponents, keep the rest in Dec".

It's your call in the end, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants