use dtAddress as did, update metadata contract #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires contracts 0.4.4 (is not released yet) |
| @@ -20,7 +20,6 @@ before_script: | |||
| - git clone https://github.com/oceanprotocol/barge | |||
| - cd barge | |||
| - git checkout v3 | |||
| - export PROVIDER_VERSION=latest | |||
| - export ADDRESS_FILE="${HOME}/.ocean/ocean-contracts/artifacts/address.json" | |||
There was a problem hiding this comment.
because of ADDRESS_FILE default in barge v3 this line can be removed too
There was a problem hiding this comment.
i would keep ADDRESS_FILE, as a reference for anyone that would want to run ocean-lib-js tests in another terminal (different from barge). both ADDRESS_FILE and AQUARIUS_URI are mandatory for the tests
Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
Co-authored-by: Matthias Kretschmann <m@kretschmann.io>
|
Code Climate has analyzed commit 8ac5f73 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 75.2%. View more on Code Climate. |
kremalicious
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #297
closes #298
closes #300