Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validate function signature changes, missing update docs and others #1914

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

add validate function signature changes, missing update docs and others #1914

wants to merge 18 commits into from

Conversation

paulo-ocean
Copy link
Contributor

@paulo-ocean paulo-ocean commented Feb 19, 2025 •
edited
Loading

Fixes #1913

Changes proposed in this PR:

  • updates Aquarius "validate" function.. node needs 'nonce', 'signature' and 'publisherAddress' to validate
  • still use legacy validate (no signatures), as backup/retry mechanism just in case provider does not support the newest changes

@paulo-ocean paulo-ocean self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc Awaiting requested review from mihaisc mihaisc will be requested when the pull request is marked ready for review mihaisc is a code owner

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 will be requested when the pull request is marked ready for review alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas will be requested when the pull request is marked ready for review bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina will be requested when the pull request is marked ready for review mariacarmina is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 will be requested when the pull request is marked ready for review jamiehewitt15 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Aquarius validate DDO call (missing some optional parameters)
1 participant
@paulo-ocean