Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ rollback microbundle package #1611

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix/ rollback microbundle package #1611

merged 1 commit into from
Sep 13, 2022

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Sep 13, 2022

Fixes # .

Changes proposed in this PR:

  • upgrading to microbundle 0.15.x breaks oceanjs build (see: oceanprotocol/market@70db079) , temporary solution downgrade microbundle to 0.14.2 then investigate the 0.15.x issues

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2022

Code Climate has analyzed commit 133059f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (0.0% change).

View more on Code Climate.

@bogdanfazakas bogdanfazakas marked this pull request as ready for review September 13, 2022 06:39
@alexcos20
Copy link
Member

ha, I was thinking about that yesterday when I bumped microbundle :(

@mihaisc mihaisc merged commit 085bc10 into main Sep 13, 2022
@mihaisc mihaisc deleted the fix/rollback-microbundle branch September 13, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants