Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/contracts alpha 26 #1358

Merged
merged 8 commits into from
Mar 21, 2022
Merged

Feature/contracts alpha 26 #1358

merged 8 commits into from
Mar 21, 2022

Conversation

alexcos20
Copy link
Member

Breaking changes:

  • fixedrate collectBT & collectDT are expecting amount as well
  • fixedrate collectBT & collectDT are sending funds to erc20.getPaymentCollector() instead of owner
  • fixedrate generateExchangeId takes only 2 params (basetoken, datatoken) , the 3rd param (owner) was removed
  • dispenser : anyone can call collect, datatokens are always sent to erc20.getPaymentCollector()
  • For ERC20Enterprise, OPC will not take 0.03DT as fee

@alexcos20 alexcos20 added this to the V4 milestone Mar 20, 2022
@alexcos20 alexcos20 requested a review from mihaisc as a code owner March 20, 2022 10:28
@alexcos20 alexcos20 self-assigned this Mar 20, 2022
@alexcos20 alexcos20 changed the title Feature/contracts alpha 23 Feature/contracts alpha 24 Mar 20, 2022
@alexcos20 alexcos20 mentioned this pull request Mar 21, 2022
Closed
@alexcos20 alexcos20 changed the title Feature/contracts alpha 24 Feature/contracts alpha 25 Mar 21, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2022

Code Climate has analyzed commit fb54dc5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 71.3%.

View more on Code Climate.

@alexcos20 alexcos20 merged commit c01fb07 into v4main Mar 21, 2022
@alexcos20 alexcos20 deleted the feature/contracts_alpha_23 branch March 21, 2022 12:40
@alexcos20 alexcos20 changed the title Feature/contracts alpha 25 Feature/contracts alpha 26 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

@kremalicious kremalicious Awaiting requested review from kremalicious

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas

Assignees

@alexcos20 alexcos20

Labels
Status: DoNotMerge
Projects
None yet
Milestone
V4
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcos20 @mihaisc