Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain Provider #1653

Closed
2 tasks
alexcos20 opened this issue Nov 15, 2022 · 0 comments · Fixed by #1698
Closed
2 tasks

Multichain Provider #1653

alexcos20 opened this issue Nov 15, 2022 · 0 comments · Fixed by #1698
Assignees

Comments

@alexcos20
Copy link
Member

alexcos20 commented Nov 15, 2022

(part of oceanprotocol/pm#185)

Make sure that chainId is available when provider cannot figure it out.
Provider will choose the corresponding web3 object based on chainId

This affects code in https://github.com/oceanprotocol/ocean.js/blob/main/src/services/Provider.ts.

Provider calls that need to be updated:

  • /api/services/encrypt - add chainId , in case Provider has different privateKeys per each chain

Provider calls that do not need updates:

  • /api/services/initialize - no need, provider will take chainId by resolving DID

  • /api/services/download - no need, provider will take chainId by resolving DID

  • /api/services/fileinfo - no need, provider will take chainId by resolving DID if DID is passed, otherwise it's just a Files object

  • POST /api/services/compute - - no need, provider will take chainId by resolving each DID (algo, datasets, etc)

  • Add integration tests for the multichain provider

  • By using this barge branch: add multichain provider in addition to existing providers barge#348 let's add a test for publish the asset, edit the metadata service and then consume the asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants