-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata, the proper way #292
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/hj553jhnt |
* output created & updated date at top of asset * use ddo.created & ddo.updated everywhere * stop pushing metadata.main.datePublished
01b34ef
to
e973ae1
Compare
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
…tocol/market into feature/metadata-update
Title seems to not have max limit, might be an issue in publish too. |
Published a data set with all blanks, including tags, |
solved most empty space issues by introducing minimum character lengths for title & description in publish & edit forms. All other validation issues are caused by Formik/Yup not validating on each So I think somewhere in our chain of |
* manually trigger onChange validation in publish & edit forms
hacked in semi-manual live-validation to fix most weirdnesses around that. The file input behaves so weird cause the blur event of the Definitely all needs to be revisited in case we add more forms but for now should be good enough. |
As for limiting the title, I would not go there cause it can be problematic. Not technically, but from user perspective where there can be many reasons to have a longer title and the problem then only lies in the UI. So we should deal with long titles somehow, like cutting them off on the asset teasers, but on asset details show them in full, ideally with some variable font size the longer it gets or something |
DebugOutput
,MetadataPreview
,MetadataFeedback
ddo.created
for showing publish date, andddo.updated
for update date, both of which are set based on block timestamp together with use block timestamp aquarius#330ddo
and other props to components, replace withuseAsset()
hook callsuseMetadata()
calls made redundant byuseAsset()
UI changes
New owner actions row only visible to data set owner:
Clicking it opens the data set edit view:
Loading view:
Success View:
When data set was updated, will be shown in the moved date output, and all dates show the exact time when hovered:
Also includes the new metadata history component, but it can't be shipped until #288 and oceanprotocol/aquarius#324 are finalized. Tracked in #282: