Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/npm-package #96

Merged
merged 6 commits into from
Jun 8, 2020
Merged

Feature/npm-package #96

merged 6 commits into from
Jun 8, 2020

Conversation

0x3bfc
Copy link

@0x3bfc 0x3bfc commented Jun 8, 2020

closes #85

@0x3bfc 0x3bfc added Type: Enhancement New feature or request Feature Status: InProgress Work in progress, don't merge labels Jun 8, 2020
@kremalicious
Copy link

kremalicious commented Jun 8, 2020

I highly suggest already setting up a proper release flow following how we do it on every other library published on npm. The key is to sync git tag, GitHub release, npm package, and version numbers in package.json & package-lock.json, and create an automatic changelog.

See e.g. for all that should be done and how it is setup in
https://github.com/oceanprotocol/react#%EF%B8%8F-releases
https://github.com/oceanprotocol/react/blob/master/package.json#L56

@0x3bfc
Copy link
Author

0x3bfc commented Jun 8, 2020

Thanks @kremalicious . Can you check the configs ?

@kremalicious
Copy link

npm run release -- --dry-run is your friend ;-)

Bt yeah, looks good and should work. You might have to create the CHANGELOG.md file already with npm run changelog but not sure, might just work once you create the first release with that command. Also suggest to just copy over the readme instructions, so the release process is documented for everyone.

@0x3bfc 0x3bfc merged commit fbfd463 into develop Jun 8, 2020
@0x3bfc 0x3bfc deleted the feature/npm-package branch June 8, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: InProgress Work in progress, don't merge Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: npm install @oceanprotocol/contracts
2 participants