Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/inconsistent naming #31

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix/inconsistent naming #31

merged 3 commits into from
May 4, 2020

Conversation

arseneeth
Copy link

Closes #29

@arseneeth arseneeth changed the title fix inconsistent naming Fix/inconsistent naming May 4, 2020
0x3bfc
0x3bfc suggested changes May 4, 2020
View reviewed changes
Copy link

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please check the solidity-coverage before merge ?

To do it just run the following command

npm run test:cover

0x3bfc
0x3bfc approved these changes May 4, 2020
View reviewed changes
Copy link

@0x3bfc 0x3bfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x3bfc 0x3bfc merged commit dd689b6 into develop May 4, 2020
@0x3bfc 0x3bfc deleted the bug/inconsistent-naming branch May 4, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x3bfc 0x3bfc 0x3bfc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arseneeth @0x3bfc