Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct order of magnitude of packages on opam #1604

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Correct order of magnitude of packages on opam #1604

merged 3 commits into from
Dec 4, 2021

Conversation

shonfeder
Copy link
Contributor

Changes Made

Opam currently has around 3.5k packages! 🎉 So this tiny wording change will give prospective users a more accurate sense of the current amount of libraries available.

  • PR is descriptively titled and links the original issue above
  • Context for what motivated the change (if this is a change to some content)

It looks me like Opam currently has around 3.5k packages! 🎉  So this tiny wording change will give prospective users a more accurate sense of the current amount of libraries available.
@patricoferris
Copy link
Contributor

Thanks @shonfeder, sounds good to me. Whilst we're at it, probably would make sense to update the French as well. From "de centaines de paquets" to "de milliers de paquets"... I think?

@Octachron
Copy link
Member

Yes, "de milliers de paquets" is the correct translation.

Also take care of the french :)
@shonfeder
Copy link
Contributor Author

Changed in the french. Hopefully correctly! Thanks for the language and pointer.

@fccm
Copy link
Contributor

fccm commented Nov 22, 2021

You changed 'centaines' by 'de milliers', there is another 'de' before the link, so it's now duplicated.

@shonfeder
Copy link
Contributor Author

shonfeder commented Nov 22, 2021

I don’t see duplicated ‘de’ in the diff. But I am also not a French speaker. I suggest a French speaker make the trivial change in whatever way is needed to make this trivial update acceptable.

@zapashcanon
Copy link
Contributor

Currently it's: Le gestionnaire de paquets OPAM vous donne accès aux multiples versions de milliers de paquets. which I can confirm to be correct.

@fccm
Copy link
Contributor

fccm commented Nov 26, 2021

Indeed it has been fixed by the second commit Update site/index.fr.md dbbc7d0
Everything's fine now.

@patricoferris patricoferris merged commit 7e219b6 into ocaml:master Dec 4, 2021
@patricoferris
Copy link
Contributor

Thanks @shonfeder and everyone else :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants