Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise 1.1.0 - native version of a JS Promise binding #16667

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

aantron
Copy link
Contributor

@aantron aantron commented Jun 18, 2020

Changelog:

@camelus
Copy link
Contributor

camelus commented Jun 18, 2020

Commit: b93cad5

A pull request by opam-seasoned @aantron.

☀️ All lint checks passed b93cad5
  • These packages passed lint tests: promise.1.1.0

☀️ Installability check (+1)
  • new installable packages (1): promise.1.1.0

@kit-ty-kate
Copy link
Member

This package fails on OCaml 4.02 with:

#=== ERROR while compiling promise.1.1.0 ======================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.02.3 | pinned(https://github.com/aantron/promise/releases/download/1.1.0/promise-1.1.0.tar.gz)
# path                 ~/.opam/4.02/.opam-switch/build/promise.1.1.0
# command              ~/.opam/4.02/bin/dune build -p promise -j 72
# exit-code            1
# env-file             ~/.opam/log/promise-24-466c54.env
# output-file          ~/.opam/log/promise-24-466c54.out
### output ###
#       ocamlc src/native/.promise.objs/byte/promise.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.02/bin/ocamlc.opt -w -40 -w +A -g -bin-annot -I src/native/.promise.objs/byte -I /home/opam/.opam/4.02/lib/result -intf-suffix .ml -no-alias-deps -open Promise__ -o src/native/.promise.objs/byte/promise.cmo -c -impl src/native/promise.re.ml)
# File "src/native/promise.re", line 481, characters 29-34:
# Warning 40: Error was selected from type Result.result.
# It is not visible in the current scope, and will not 
# be selected if the type becomes unknown.
# File "src/native/promise.re", line 481, characters 29-34:
# Warning 42: this use of Error required disambiguation.
# File "src/native/promise.re", line 600, characters 8-10:
# Error: Unbound constructor Ok
#     ocamlopt src/native/.promise.objs/native/promise.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.02/bin/ocamlopt.opt -w -40 -w +A -g -I src/native/.promise.objs/byte -I src/native/.promise.objs/native -I /home/opam/.opam/4.02/lib/result -intf-suffix .ml -no-alias-deps -open Promise__ -o src/native/.promise.objs/native/promise.cmx -c -impl src/native/promise.re.ml)
# File "src/native/promise.re", line 481, characters 29-34:
# Warning 40: Error was selected from type Result.result.
# It is not visible in the current scope, and will not 
# be selected if the type becomes unknown.
# File "src/native/promise.re", line 481, characters 29-34:
# Warning 42: this use of Error required disambiguation.
# File "src/native/promise.re", line 600, characters 8-10:
# Error: Unbound constructor Ok

@aantron
Copy link
Contributor Author

aantron commented Jun 21, 2020

Thanks. That should be fixed in the new archive.

@avsm avsm merged commit ffd635a into ocaml:master Jun 23, 2020
@avsm
Copy link
Member

avsm commented Jun 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants