Unshadow run_and_read #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of `Command.run_and_read` can break code as it shadows `My_unix.run_and_read` and has a different type. This is fixed here by renaming the function to `run_spec_and_read`. See ocaml#353 (comment) for an example of breakage in the wild.
c348ab1 to
e9efc7d
Compare
Closed
|
I decided to accept my own proposal :-) I think this is good enough and will let me release a fixed 0.16 version quickly. |
|
(The build of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the compatibility breakage due to the shadowing of
My_unix.run_and_readbyCommand.run_and_read: the new function is now calledCommand.run_spec_and_read.(I tried to understand why we care about having this function at all, and discovered another place in the codebase where it could/should be used -- we run
ocamlc -whereat runtime to locate the stdlib. I went ahead and used it there as well.)