Rename EffectHandlers module to Effect #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is a bootstrap necessary? |
|
It failed without it, but that might have been due to some lingering dependency. Let me drop the bootstrap with a clean tree and try again. |
This makes the name more consistent with the rest of the stdlib, and neatly avoids a choice of snake or camelcase. Discussed on caml-devel in December.
8ed4ceb to
05ce8fa
Compare
|
And it works fine without bootstrap with a |
OlivierNicole
added a commit
to OlivierNicole/domainslib
that referenced
this pull request
Jan 17, 2022
The renaming was made by ocaml/ocaml#10879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the name more consistent with the rest of the stdlib, and neatly avoids a choice of snake or camelcase. Discussed on caml-devel in December and one of the post-multicore-merge tasks in #10861.
Will require some changes in domainslib/eio to follow once merged, and in opam-repository in the base-effects package.