Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add white color #1595

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add white color #1595

merged 3 commits into from
Oct 20, 2023

Conversation

Isaranwa
Copy link
Contributor

@Isaranwa Isaranwa commented Oct 8, 2023 •
edited by sabine
Loading

Resolves #1577.

The aim was to change the text color of the ocaml playground color from red to white.
play

sabine
sabine reviewed Oct 8, 2023
View reviewed changes
@gpetiot gpetiot added the outreachy Outreachy contributions and blog posts label Oct 9, 2023
@sabine
Copy link
Collaborator

sabine commented Oct 12, 2023

@Isaranwa are you up for making the requested changes?

  1. check if the REPL response is still white when o.stderr renders as red
  2. remove the file that doesn't belong in this PR

@sabine
Copy link
Collaborator

sabine commented Oct 20, 2023

Thanks for the contribution @Isaranwa!

@sabine sabine merged commit e8adf3a into ocaml:main Oct 20, 2023
cuihtlauac pushed a commit that referenced this pull request Nov 15, 2023
@Isaranwa
Change Playground Output Color from Red to White (#1595)
eec8b10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabine sabine sabine left review comments

Assignees
No one assigned
Labels
outreachy Outreachy contributions and blog posts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the Output Color on the Playground From Red to White
3 participants
@Isaranwa @sabine @gpetiot