fix(go-to-def): report error in response #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-to-decl/go-to-type-def rather than sending a notification afterwards with the error
rgrinberg
reviewed
Oct 26, 2022
Yes it does, good catch. However, I prefer |
rgrinberg
reviewed
Oct 26, 2022
rgrinberg
approved these changes
Oct 27, 2022
Khady
added a commit
to Khady/ocaml-lsp
that referenced
this pull request
Nov 4, 2022
* master: fix(go-to-def): report error in response (ocaml#899) Update readme (ocaml#895) chore(nix): update flakes and dune-release (ocaml#894) chore: remove ocamlformat-rpc (ocaml#892) chore(nix): pass opam-repository and nixpkgs (ocaml#893) chore: unvendor ocamlc-loc (ocaml#869) fix: merlin document safety (ocaml#890) chore: more precise CHANGES (ocaml#889) fix: diagnostics on non dune files (ocaml#887) refactor: remove Document.is_merlin (ocaml#888) fix: symbols in non merlin docs (ocaml#886) refactor: style tweaks in document_symbol (ocaml#885) fix: handle incorrect document types (ocaml#884) Ignore unknown config tags (ocaml#883) Make sure nodejs packages required are installed chore: prepare 1.14.0 Don't let opam ask when not needed Allow copy-and-paste of contributing instructions Add code action for inlining (ocaml#847) Add note about protocol extensions to the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(go-to-def): send a response with an error for failing go-to-def/go-to-decl/go-to-type-def
rather than a notification afterwards with the error
also, should
definition_query's body be wrapped inFiber.of_thunk?