Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make domainslib build/run with OCaml 5.00 after PR #704 #53

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

bikallem
Copy link
Contributor

@bikallem bikallem commented Oct 22, 2021

Updated CI to use opam repo @ https://github.com/kit-ty-kate/multicore-opam. So that we can use the ocaml 5.00 switch. (4.14.0+domains).

This will probably need to be reverted to original multicore-opam once the changes from kit-ty-kate is merged.

Note: After this PR is merged domainslib will be incompatible with 4.12.0+domains switch. We need to cherry pick PR#704 from 5.00 branch to 4.12.0+domains branch. The latter is no longer the case after ocaml-multicore/ocaml-multicore#718

@bikallem
Copy link
Contributor Author

bikallem commented Oct 22, 2021

ci with 5.00 works correctly. https://github.com/bikallem/domainslib/actions/runs/1372140682.

I am working on cherry-picking PR#704 to 4.12+domains/4.12+domains+effects. After which I will re-enable the ci for 4.12+domains branches again.

edit: converted the PR into a draft as I am still waiting for ocaml-multicore/ocaml-multicore#718 to be merged into 4.12.0+domains branches

@bikallem bikallem changed the title Make domainslib build/run with OCaml 5.00 after PR #704 [Draft] Make domainslib build/run with OCaml 5.00 after PR #704 Oct 25, 2021
@bikallem bikallem changed the title [Draft] Make domainslib build/run with OCaml 5.00 after PR #704 Make domainslib build/run with OCaml 5.00 after PR #704 Oct 26, 2021
@bikallem bikallem marked this pull request as draft October 26, 2021 11:30
@bikallem bikallem requested review from ctk21 and Sudha247 October 26, 2021 11:32
@kayceesrk
Copy link
Contributor

Note: After this PR is merged domainslib will be incompatible with 4.12.0+domains switch. We need to cherry pick PR#704 from 5.00 branch to 4.12.0+domains branch.

IINM for the Tezos work, @Sudha247 is using 4.12.0+domains, isn't it?

@Sudha247
Copy link
Contributor

IINM for the Tezos work, @Sudha247 is using 4.12.0+domains, isn't it?

Yes, that's right. I think domainslib should work on 4.12.0+domains once ocaml-multicore/ocaml-multicore#718 is pushed to 4.12.0+domains branch.

@bikallem bikallem force-pushed the ocaml-5.00 branch 2 times, most recently from 38a65cb to 50a75d9 Compare October 27, 2021 13:17
@bikallem bikallem marked this pull request as ready for review October 27, 2021 14:23
@bikallem
Copy link
Contributor Author

bikallem commented Oct 27, 2021

hurrah! ci is finally green with the latest 4.12+domains+effects and 4.12+domains switches.
ready for review.

/cc @Sudha247 @ctk21

Copy link
Contributor

@Sudha247 Sudha247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to go, barring a minor comment on mirage-clock-unix.

@bikallem bikallem requested a review from Sudha247 October 28, 2021 08:33
@Sudha247
Copy link
Contributor

Merging.

@Sudha247 Sudha247 merged commit 0931282 into ocaml-multicore:master Oct 28, 2021
@bikallem bikallem deleted the ocaml-5.00 branch October 28, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants