-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make domainslib build/run with OCaml 5.00 after PR #704 #53
Conversation
ci with 5.00 works correctly. https://github.com/bikallem/domainslib/actions/runs/1372140682.
edit: converted the PR into a draft as I am still waiting for ocaml-multicore/ocaml-multicore#718 to be merged into 4.12.0+domains branches |
IINM for the Tezos work, @Sudha247 is using |
Yes, that's right. I think domainslib should work on |
38a65cb
to
50a75d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to go, barring a minor comment on mirage-clock-unix
.
Merging. |
Updated CI to use opam repo @ https://github.com/kit-ty-kate/multicore-opam. So that we can use the ocaml 5.00 switch. (4.14.0+domains).
This will probably need to be reverted to original multicore-opam once the changes from kit-ty-kate is merged.
Note: After this PR is merged domainslib will be incompatible withThe latter is no longer the case after ocaml-multicore/ocaml-multicore#7184.12.0+domains
switch. We need to cherry pick PR#704 from 5.00 branch to 4.12.0+domains branch.