Add parallel scan #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayceesrk
reviewed
Apr 24, 2020
lib/task.ml
Outdated
| ~body:(fun i -> | ||
| let s = (i * n) / (p ) in | ||
| let e = (i + 1) * n / (p ) - 1 in | ||
| (* Printf.printf "s = %d e = %d\n" s e; *) |
lib/task.mli
Outdated
|
|
||
| val parallel_scan : pool -> ('a -> 'a -> 'a) -> 'a array -> 'a array | ||
| (** [parallel_scan p op a] computes the scan of the array a | ||
| * in parallel with binary operator op and returns the result array. |
There was a problem hiding this comment.
Suggested change
| * in parallel with binary operator op and returns the result array. | |
| * in parallel with binary operator [op] and returns the result array. |
lib/task.mli
Outdated
| @@ -39,3 +39,9 @@ val parallel_for_reduce : pool -> ('a -> 'a -> 'a) -> 'a -> chunk_size:int -> | |||
| (** [parallel_for_reduce p r i c s f b] is similar to [parallel_for] except | |||
| * that the result returned by each iteration is reduced with [r] with initial | |||
| * value [i]. *) | |||
|
|
|||
| val parallel_scan : pool -> ('a -> 'a -> 'a) -> 'a array -> 'a array | |||
| (** [parallel_scan p op a] computes the scan of the array a | |||
There was a problem hiding this comment.
Suggested change
| (** [parallel_scan p op a] computes the scan of the array a | |
| (** [parallel_scan p op a] computes the scan of the array [a] |
lib/task.mli
Outdated
| val parallel_scan : pool -> ('a -> 'a -> 'a) -> 'a array -> 'a array | ||
| (** [parallel_scan p op a] computes the scan of the array a | ||
| * in parallel with binary operator op and returns the result array. | ||
| * Scan is similar to Array.fold_left but returns an array of reduced |
There was a problem hiding this comment.
Suggested change
| * Scan is similar to Array.fold_left but returns an array of reduced | |
| * Scan is similar to [Array.fold_left] but returns an array of reduced |
|
Can you comment on how this scales @Sudha247? |
|
These are some numbers for the
|
|
Thanks. I'll merge this one. We should revisit the performance. I would be curious to know where the overheads lie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.