Support other OCaml versions through 5.1 AST #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mlx toolchain is based on OCaml 5.1 parset and AST (we cherry pick source code for mlx and ocamlmerlin-mlx package). Then we use ppxlib to convert from 5.1 AST to the current OCaml AST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently mlx copies parser/AST from OCaml 5.1 and ocamlmerlin-mlx copies parser/AST (and everything else needed) from merlin's 510 branch (corresponds to 5.1 OCaml version).
So we say that mlx toolchain is based on OCaml 5.1.
Now to support other OCaml versions we need:
This PR implements this with the help of ppxlib. Unfortunately 1. point above requires venturing more Merlin code and some Obj.magic (but hopefully we can get rid of it soon).