Zed_utf8.next_error: raise Zed_utf8.Out_of_bounds in case of invalid offset.
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fcf3da to
34a102c
Compare
c82b028 to
0d927c3
Compare
tmattio
reviewed
Mar 6, 2023
src/zed_utf8.mli
Outdated
Comment on lines
49
to
53
| [ofs] is [String.length str] and [msg] is the empty string. | ||
| @raise [Zed_utf8.Out_of_bounds] if [ofs] not an index of [str]. | ||
| *) |
There was a problem hiding this comment.
Suggested change
| [ofs] is [String.length str] and [msg] is the empty string. | |
| @raise [Zed_utf8.Out_of_bounds] if [ofs] not an index of [str]. | |
| *) | |
| [ofs] is [String.length str] and [msg] is the empty string. | |
| @raise [Zed_utf8.Out_of_bounds] if [ofs] is not an index of [str]. *) |
There was a problem hiding this comment.
The function seems to be raising Invalid as well, could you add it to the documentation at the same time?
fe2d1e8 to
15925e3
Compare
tmattio
reviewed
Mar 7, 2023
src/zed_utf8.mli
Outdated
Comment on lines
51
to
53
| @raise [Zed_utf8.Invalid] if [str] is not a correct UTF8 sequence. | ||
| @raise [Zed_utf8.Out_of_bounds] if [ofs] not an index of [str]. | ||
| *) |
There was a problem hiding this comment.
Small formatting fix:
Suggested change
| @raise [Zed_utf8.Invalid] if [str] is not a correct UTF8 sequence. | |
| @raise [Zed_utf8.Out_of_bounds] if [ofs] not an index of [str]. | |
| *) | |
| @raise [Zed_utf8.Invalid] if [str] is not a correct UTF8 sequence. | |
| @raise [Zed_utf8.Out_of_bounds] if [ofs] not an index of [str]. *) |
15925e3 to
3e9e005
Compare
tmattio
approved these changes
Mar 10, 2023
|
Looks good to me too. |
tmattio
added a commit
to tmattio/opam-repository
that referenced
this pull request
Jun 20, 2023
CHANGES: * `Zed_utf8.next_error`: raise `Zed_utf8.Out_of_bounds` in case of invalid offset (@Lucccyo, ocaml-community/zed#52) * `kill_next_word` should not raise `Out_of_bound` (@Lucccyo, ocaml-community/zed#55) * `of_utf8`: add `Uchar.is_valid` to check the input (@Lucccyo, ocaml-community/zed#51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zed_utf8.next_error string offsetshould fail withZed_utf8.Out_of_bounds, whenoffsetdoes not belong to a valid range (from 0 tostring's length).