-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Owl GC regression test case. #464
Conversation
bfa2096
to
14b7796
Compare
Thanks for taking the time to contribute this PR! I've updated this PR to correctly install the dependencies for owl. The problem was that the But, I've been unable to run the benchmark itself (on
We use |
14b7796
to
5b14738
Compare
Rather than adding empty parameters, I think it is better to remove the reporting part from the benchmark (the last |
The reporting part from the benchmark can be removed, yes. 👍 The last commit adds empty params field to the |
Sorry, I misread the last commit as a fix for the invalid argument error which comes from the report section of the benchmark. |
cd0fba9
to
b334554
Compare
I've squashed the last commit into the first one; And also removed the reporting part of the benchmark. I think we should be good to merge this, once the github action finishes. |
Originally taken from https://gitlab.inria.fr/fangelet/ocaml-gc-regression-examples and supplied by Florian Angeletti (@Octachron)
b334554
to
e6e5999
Compare
Thanks @punchagan |
@tmcgilchrist added an Owl GC regression test case in ocaml-bench/sandmark#464 and the results for 5.0 and 5.2 versions are required for a comparison.
@tmcgilchrist added an Owl GC regression test case in ocaml-bench/sandmark#464 and the results for 5.0 and 5.2 versions are required for a comparison.
Originally taken from
https://gitlab.inria.fr/fangelet/ocaml-gc-regression-examples and supplied by Florian Angeletti (@Octachron). This code was supplied on Performance regression with multiple domains between 5.0 and 5.1.
This test will output timings to stdout of the form
4.14.1 | 2.395s | 1949 | 487
representingcompiler version, time, minor GC, major GC
. How will that output be captured by sandmark or is there instrumentation already to capture this sort of GC information?