Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix focuse aware statue bar crash in web #403

Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix: fix focuse aware statue bar crash in web #403

merged 1 commit into from
Nov 23, 2024

Conversation

hamzamekk
Copy link
Contributor

What does this do?

  • Removes SystemBars rendering on web

Why did you do this?

  • SystemBars is a native-only component and was causing runtime errors in browser

Who/what does this impact?

  • Fixes web application crashes
  • No changes to native mobile functionality

How did you test this?

  • Verified web app loads without crashes
  • Confirmed native StatusBar still works on iOS/Android

@hamzamekk hamzamekk requested a review from yjose November 22, 2024 23:56
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

✅ Deploy Preview for obytes-starter canceled.

Name Link
🔨 Latest commit dfe5bfb
🔍 Latest deploy log https://app.netlify.com/sites/obytes-starter/deploys/67411a313c9952000827d9d4

@github-actions GitHub Actions
Copy link
Contributor

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 40%
 39.33% (188/478) 33.93% (75/221) 26.48% (49/185)

😎 Tests Results

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 27.028s ⏱️
👀 Tests Details • (40%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files39.3333.9326.4840.17 
components/ui71.0352.1762.570.78 
   focus-aware-status-bar.tsx16.6600209–14

@yjose yjose merged commit fbb52ca into master Nov 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjose yjose yjose approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamzamekk @yjose