chore: fix husky deprecated warning #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obytes-starter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yjose
reviewed
Nov 9, 2024
.husky/pre-commit
Outdated
| @@ -1,5 +1,4 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
@Gaulepal this line should be deleted too , right?
There was a problem hiding this comment.
hello @yjose I have no idea how does it work on Windows machine (macOS user). Repo seems to have common.sh inside the .husky directory. Please see the associated file. I leave you or other experts to change accordingly. Thanks
yjose
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
After the
pnpm install, got the followingwarningswhile committing the changes.Why did you do this?
It seems that after the release of version 9.0.1 (https://github.com/typicode/husky/releases/tag/v9.0.1) indicate those two lines were deprecated and need to be removed.
How to Migratesection in the release notes.Who/what does this impact?
Does not have significant impact but definitely improve the DX.
How did you test this?
You need to clone the project and
pnpm i