Determine whether a reboot is necessary when deploying, and take the appropriate action #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a03c2a5 to
d91d680
Compare
Ericson2314
approved these changes
Aug 3, 2022
Ericson2314
reviewed
Aug 3, 2022
Comment on lines
+252
to
+255
| -- Note that we don't want to $(staticWhich "nix-env") here, because this is executing on a remote machine | ||
| -- This logic follows the nixos auto-upgrade module as of writing. | ||
| -- If the workflow is added to switch-to-configuration proper, we can simplify this: | ||
| -- https://github.com/obsidiansystems/obelisk/issues/958 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: #955
We use the same logic as as the NixOS auto-upgrade module. Though unfortunately, not in a way where we keep apace if that logic were to change. C'est la vie. See: NixOS/nixpkgs#185030
I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)