Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include flag to use relative paths. Absolute paths are now default. #934

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

romefeller
Copy link
Contributor

@romefeller romefeller commented Jun 10, 2022

Fixing the relative path problem on macos. A new option was created --use-relative-path. Absolute paths are now defaulted.

See: #899

Usage:

ob run --use-relative-path

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, please minimize indentation and remove any trailing white space. I find it helpful to configure my editor to highlight trailing white space in red.

@madeline-os madeline-os merged commit c7e9b8d into develop Jun 15, 2022
plt-amy added a commit that referenced this pull request Aug 24, 2022
* Add link for #889
* Add space between #934 and #936
* Reword #974
* Fix #959 link
* Wrap all identifiers, commands, etc in backticks
* Sort changelog chronologically
@zongwu233
Copy link

Hasn't this merge been published yet? on MacOS 10.15.7
ob run --use-relative-path command failed :
Invalid option '--use-relative-path'

@ali-abrar
Copy link
Member

Which branch of obelisk are you using? This is on develop but I'm not sure it's made it to an official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants