-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add externs.js file to deal with name clashes between generated and external javascript #903
Conversation
Need to update the docs, will do it next week on Monday. |
I wonder if we should have a sample externs.js with commented contents used in the skeleton so it's more discoverable. Then the FAQ could just link to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I agree that we should add an example to the skeleton. Once we have that, I will approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion, we have decided that the best course of action is to fix this with automation before we bless a solution in the skeleton.
I have:
develop
branchhlint .
(lint found code you did not write can be left alone) - Did not change Haskell code.$(nix-build -A selftest --no-out-link)
nix-build release.nix -A build.x86_64-linux --no-out-link
(orx86_64-darwin
on macOS)