Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add externs.js file to deal with name clashes between generated and external javascript #903

Merged
merged 8 commits into from
May 17, 2022

Conversation

ohri-anurag
Copy link
Contributor

@ohri-anurag ohri-anurag commented Mar 10, 2022

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone) - Did not change Haskell code.
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@ohri-anurag
Copy link
Contributor Author

Need to update the docs, will do it next week on Monday.

@madeline-os madeline-os changed the title Added externs file for Kadena Chainweaver Add externs.js file to deal with name clashes between generated and external javascript Mar 11, 2022
@alexfmpe
Copy link
Collaborator

I wonder if we should have a sample externs.js with commented contents used in the skeleton so it's more discoverable. Then the FAQ could just link to it.

Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I agree that we should add an example to the skeleton. Once we have that, I will approve :)

Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, we have decided that the best course of action is to fix this with automation before we bless a solution in the skeleton.

@madeline-os madeline-os merged commit b6b219a into develop May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants