Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-interpret hint to ob shell #784

Merged
merged 6 commits into from
May 11, 2022
Merged

Add --no-interpret hint to ob shell #784

merged 6 commits into from
May 11, 2022

Conversation

tomsmalley
Copy link
Collaborator

@tomsmalley tomsmalley commented Jul 10, 2020 •
edited
Loading

I have:

  • Based work on latest develop branch
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@augyg augyg assigned augyg and unassigned augyg May 5, 2022
@augyg augyg requested a review from madeline-os May 6, 2022 16:55
madeline-os
madeline-os requested changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fine enough change. Please add a line in the CHANGELOG.md and ensure that other requirements of the contribution guidelines have been satisfied.

@madeline-os madeline-os merged commit 4e07ca2 into develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeline-os madeline-os madeline-os approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomsmalley @madeline-os @augyg @ali-abrar